pisoj/dhowden-tag
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
149 Commits 1 Branch 0 Tags
34f7f1e3c8f6e0f3573f7e7501c82b13eff5dc27
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
David Howden c555fff0b7 Merge branch 'jooola-tag_test' 2018-09-21 19:02:25 +10:00
David Howden 222f0b2988 Merge string trimming for id3v1 into single method 2018-09-21 18:58:54 +10:00
David Howden e80a3fa76a update to use new io.Seek consts, require min go1.7 2018-04-02 11:06:41 +10:00
David Howden 1264d437b3 cmd: tidy up flag usage 2018-04-02 10:54:32 +10:00
David Howden f163d543fb id3v2: remove unused method and merge declaration 2018-04-02 08:18:11 +10:00
David Howden 964345f10f fix const declarations 2018-04-02 08:17:25 +10:00
David Howden 3fc65dddfc id3v2: fix variable name and pre-compute genre regexp 2018-04-02 08:17:10 +10:00
David Howden 4f91c64763 id3v2: tidy up dataSplit and decodeText 2018-04-02 08:16:46 +10:00
David Howden 610452ee64 tools: move to cmd subdir 2018-04-02 08:14:54 +10:00
David Howden ba105bfefc id3v2: fix panic on invalid encoding of UTF-16 text 2018-02-19 18:01:22 +11:00
David Howden d2206af145 mp4: fix panic on invalid encoding 2018-02-17 13:07:03 +11:00
David Howden d449289c5e vorbis: fix panic on invalid encoding 
Fixes #33
 2018-02-07 18:37:07 +11:00
David Howden 1582ebc2a4 mp4: fix panic on invalid encoding 
Fixes #32
 2018-02-07 18:36:47 +11:00
David Howden 737d3560dd mp4: fix panic on invalid encoding 
Fixes #31
 2018-02-07 18:36:17 +11:00
David Howden 3066d30077 Merge branch 'thraxil-master' 2017-10-22 22:23:05 +11:00
David Howden e24fc33f60 Fix Format and FileType enumerations, and incorrect Format() for OGG. 2017-09-14 08:55:56 +10:00
David Howden 5e368ba94d Fix parsing of year in ID3v2.4 
Fixes #27
 2017-09-14 08:43:05 +10:00
David Howden b45cd4d440 Update README.md 
Use console lang for console output.
 2017-08-01 22:29:01 +10:00
David Howden 9edd38ca5d Update README to set language on code snippets. 2017-01-29 10:14:22 +11:00
David Howden 0b712361d3 Merge branch 'upperstream-id3v1-track-and-comment' 2016-07-17 09:10:21 +10:00
David Howden 028d342425 Merge branch 'fallback-decode-iso-8859-1' 2016-07-11 12:51:03 -06:00
David Howden 9daeb83105 Update delimiter to fallback to ISO-8859-1. 2016-05-09 22:40:03 +10:00
David Howden bfba4b35ab Updated text decoding to fallback to ISO-8859-1. 
See #20 for more details.
 2016-05-09 22:37:19 +10:00
David Howden 1c1d74b935 Merge pull request #24 from wader/skip-extended-header 
Read and skip extended header bytes for 2.3 and 2.4
 2016-05-06 06:50:24 +10:00
David Howden 66b965ab49 Merge pull request #23 from dhowden/vorbis-albumartist 
Set Vorbis.AlbumArtist to return "albumartist" attribute.
 2016-04-21 07:00:30 +10:00
David Howden 4cd9615aa1 Set Vorbis.AlbumArtist to return "albumartist" attribute. 2016-04-20 21:52:54 +10:00
David Howden bccc91e40d Fix: Detect PNG artwork when class = 0 (implicit) is set. 
TODO: We should also try to detect JPEG artwork, but JPEG headers are a bit more tricky.

Fixes #19.
 2016-03-06 22:24:05 +11:00
David Howden a55be0e8bf check: Don't break on URL parsing error. 2016-03-06 22:21:54 +11:00
David Howden 996bee7eb6 Fix panic when picture isn't properly parsed. 
See issue #19.
 2016-03-05 16:17:11 +11:00
David Howden a35ac09042 Distinguish between M4{A,B,P} formats. 
Note: Removes tag.AAC.
 2016-02-22 21:01:12 +11:00
David Howden 5b94194b29 Remove unused error parameter, and tidy up implementation. 2016-01-03 23:05:17 +11:00
David Howden 030e21e7c2 Added DefaultUTF16WithBOMByteOrder for instances where no BOM is given. 2016-01-03 23:00:45 +11:00
David Howden 5fe43c28e4 Merge pull request #17 from wader/com-ult-frames 
Add COM and ULT text frames
 2016-01-03 08:39:49 +11:00
David Howden dc1f3d7b51 Merge pull request #16 from wader/all-ftyp 
Parse all ftyp:s as mp4
 2015-12-29 13:25:45 +11:00
David Howden c259675f29 Use switch in place of multiple if statements. 2015-09-20 20:13:12 +10:00
David Howden 554fadb2b4 Added Sum support for FLAC 2015-09-20 20:09:42 +10:00
David Howden 549eab9b75 Merge pull request #14 from xhenner/itunes 
Be a little less strict on invalid frames
 2015-07-12 11:27:14 +10:00
David Howden 334c71001c Merge pull request #13 from xhenner/genre 
Support for numeric genres in id3v2
 2015-07-04 22:49:17 +10:00
David Howden 62e2154cad Fix godoc comment. 2015-07-03 23:15:16 +10:00
David Howden 78f72c23bd Added Identity to check tool. 2015-07-02 23:07:50 +10:00
David Howden b60e529091 Add Identity function for identifying metadata/filetypes. 2015-07-02 23:07:17 +10:00
David Howden 92e6d71ddb Refactor common code to skip last 128 bytes from ReadSeeker. 2015-06-30 23:07:26 +10:00
David Howden 52902f61b8 Switch to using relative seeks only (last remaining call using SEEK_SET). 2015-06-30 23:06:50 +10:00
David Howden 00cce15102 Remove unnecessary recursion. 2015-06-30 23:05:59 +10:00
David Howden 0b455fc176 Write straight to hash function instead of buffering. 2015-06-30 08:58:55 +10:00
David Howden 6021704ba3 Seek over next_item_id instead of reading it. 2015-06-30 08:57:03 +10:00
David Howden 6d208fee69 Remove unnecessary case in SumAtoms. 2015-06-30 08:56:21 +10:00
David Howden cc382c48de Tidy up visibility of internal-only types. 2015-06-28 12:40:49 +10:00
David Howden 6af476df94 Correctly parse ID3 2.3 and 2.4 frame flags. 
Note: wasn't causing any know issues, but needed to be made consistent with the spec!
 2015-06-28 12:34:42 +10:00
David Howden bda3a1fa8b Fixed package doc comment 2015-06-28 11:25:07 +10:00
David Howden 3e7020b161 Added license and godoc to check. 2015-06-28 10:47:45 +10:00
David Howden 17f4f77bef Update README to include simple code example. 
Fix small grammatical error too!
 2015-06-28 10:43:57 +10:00
David Howden a579928cb2 Add simple example and improve ReadFrom godoc. 2015-06-28 10:32:57 +10:00
David Howden cc7e8af340 Remove unnecessary continue, and add some spacing. 2015-06-28 09:53:57 +10:00
David Howden 624837fdc1 Remove unnecessary TrimSpace for tag name. 2015-06-28 09:53:37 +10:00
David Howden db723fecfc Check each ID3 tag is valid. 
Some tag encoders like to use non-standard padding (see http://id3.org/Compliance%20Issues) which was causing "unexpected EOF" errors.  Checking that each tag has a valid name (as per the spec) seems to be the only good way around this.
 2015-06-28 09:53:07 +10:00
David Howden 1b0e92375a Fix: panic on empty description in text-description frames. 2015-06-27 19:24:33 +10:00
David Howden d3e0c4a33f Simplify MusicBrainz Info type and support more tags. 2015-06-08 11:01:32 +10:00
David Howden c06066fd88 Updated package godoc comment. 2015-06-07 13:01:12 +10:00
David Howden 6df4e78d96 Remove non-relative Seek calls from all functions. 
Previously we would seek to the beginning of the io.ReadSeeker. It is much more
flexible to assume that the caller passes the ReadSeeker in an appropriate state.
 2015-06-07 12:58:58 +10:00
David Howden 7f8f21cc46 Added flag.Usage output to check tool. 2015-06-07 12:54:44 +10:00
David Howden 4d2e737694 Remove old TODO comment. 2015-06-06 16:35:44 +10:00
David Howden ddaa43f29c Added some more godoc comments. 2015-06-06 16:35:44 +10:00
David Howden 6cd7fd8f70 Added -mbz option to tag tool to output MusicBrainz information. 2015-06-06 16:35:44 +10:00
David Howden e7f103ff85 Improved default usage output to use flag.PrintDefaults(). 2015-06-06 16:35:44 +10:00
David Howden 9534e41d81 Added mbz subpackage for extracting MusicBrainz-specific tags. 
This is a rewrite of pull request #11 which was a first attempt at this (thanks @xhenner for starting this).
 2015-06-06 16:35:39 +10:00
David Howden d03fdf9fb5 Remove debugging output 2015-05-27 18:58:35 +10:00
David Howden 36d9163868 Refactored all MP4 code to better handle custom atoms 2015-05-27 08:43:47 +10:00
David Howden e6dce4ae2a Merge branch 'xhenner-allmp4' 2015-05-25 22:50:42 +10:00
David Howden 3f92286cdb Merge branch 'allmp4' of https://github.com/xhenner/tag into xhenner-allmp4 2015-05-25 22:36:14 +10:00
David Howden ffefb50681 Merge pull request #9 from xhenner/allid3v2 
Fix a bug in Sum() and add all id3frames in Raw()
 2015-05-25 07:36:38 +10:00
David Howden 5ed21afced Added Lyrics() to README 2015-05-24 22:49:06 +10:00
David Howden 8bdc82eff0 Added Genre() to Metadata interface 2015-05-24 22:37:21 +10:00
David Howden ce0c1dc2f8 Remove append no-op! 2015-05-24 13:13:43 +10:00
David Howden 2cbec0cf93 Fix panic when len(result[1]) == 0 2015-05-24 13:13:32 +10:00
David Howden 47d9285956 Small refactor to dataSplit 2015-05-24 13:13:06 +10:00
David Howden 5da0ca1f03 Removed unnecessary space 2015-05-24 12:23:31 +10:00
David Howden 7d23e28e65 Refactor readTextWithDescr function 2015-05-24 12:23:30 +10:00
David Howden b55f474bf9 Refactor readTFrame and added readWFrame 2015-05-24 12:23:30 +10:00
David Howden f782cbdf44 Add check for size of provider/identifier split 2015-05-24 12:23:30 +10:00
David Howden 1832dec4e7 Refactor Ufid -> UFID 2015-05-24 12:23:30 +10:00
David Howden 255636cc34 Update README to add OGG 2015-05-24 11:29:38 +10:00
David Howden 4c2b34fa94 Reorganised Vorbis Comment parsing into own type 
- Added FileType to Metadata to distinguish between FLAC and OGG
- TODO: fix ALAC files being identified as AAC
 2015-05-24 10:44:45 +10:00
David Howden 77d9aa6414 Added tool for checking tags over iTunes Library or path 2015-05-24 09:52:44 +10:00
David Howden e5e85d7360 Merge branch 'Simon-L-master' 2015-05-24 09:50:28 +10:00
David Howden e5ad564af4 Added Lyrics output to tag tool 2015-05-19 22:10:04 +10:00
David Howden 68d82a6107 Fix errors caused by incorrect delimiters 2015-05-19 22:09:51 +10:00
David Howden 3c6f62d3e8 Merge pull request #5 from dhowden/revert-4-lyrics 
Revert "Add support for lyrics."
 2015-05-19 08:04:14 +10:00
David Howden c895efbcf8 Revert "Add support for lyrics." 2015-05-19 08:03:36 +10:00
David Howden 90c5402ab5 Merge pull request #4 from xhenner/lyrics 
Add support for lyrics.
 2015-05-19 07:22:52 +10:00
David Howden 7a80548ea8 Add some basic tests for utils 2015-05-03 09:59:03 +10:00
David Howden 23cb126fb7 Add license comment to unsynchroniser tests 2015-05-03 09:58:40 +10:00
David Howden 0203dd6bc4 Tidy up unsynchroniser.Read some more 2015-05-03 09:58:13 +10:00
David Howden 5989e00ece Simplified unsynchroniser and added tests 2015-05-02 09:58:05 +10:00
David Howden 5ddbd701bc Merge branch 'xhenner-master' 2015-05-02 09:54:31 +10:00
David Howden 07ab8d2572 Fix merge conflicts 2015-05-02 09:53:58 +10:00
David Howden b549899eb9 Merge pull request #3 from solarnz/editorconfig 
Add a basic editorconfig file
 2015-05-01 23:13:13 +10:00
David Howden de3f502e83 Improved handling of multiple tags with the same name 2015-04-27 23:11:04 +10:00
David Howden 0f6115b228 Fixed panic on tag name length < 4 2015-04-27 22:55:59 +10:00
David Howden 4b3edce02f Fixed godoc 2015-04-27 22:53:37 +10:00