pisoj/dhowden-tag
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
89 Commits 1 Branch 0 Tags
52902f61b8d65bfe0d75b27ad5033103264aae4b
Commit Graph
72 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
David Howden 52902f61b8 Switch to using relative seeks only (last remaining call using SEEK_SET). 2015-06-30 23:06:50 +10:00
David Howden 00cce15102 Remove unnecessary recursion. 2015-06-30 23:05:59 +10:00
David Howden 0b455fc176 Write straight to hash function instead of buffering. 2015-06-30 08:58:55 +10:00
David Howden 6021704ba3 Seek over next_item_id instead of reading it. 2015-06-30 08:57:03 +10:00
David Howden 6d208fee69 Remove unnecessary case in SumAtoms. 2015-06-30 08:56:21 +10:00
David Howden cc382c48de Tidy up visibility of internal-only types. 2015-06-28 12:40:49 +10:00
David Howden 6af476df94 Correctly parse ID3 2.3 and 2.4 frame flags. 
Note: wasn't causing any know issues, but needed to be made consistent with the spec!
 2015-06-28 12:34:42 +10:00
David Howden bda3a1fa8b Fixed package doc comment 2015-06-28 11:25:07 +10:00
David Howden 3e7020b161 Added license and godoc to check. 2015-06-28 10:47:45 +10:00
David Howden 17f4f77bef Update README to include simple code example. 
Fix small grammatical error too!
 2015-06-28 10:43:57 +10:00
David Howden a579928cb2 Add simple example and improve ReadFrom godoc. 2015-06-28 10:32:57 +10:00
David Howden cc7e8af340 Remove unnecessary continue, and add some spacing. 2015-06-28 09:53:57 +10:00
David Howden 624837fdc1 Remove unnecessary TrimSpace for tag name. 2015-06-28 09:53:37 +10:00
David Howden db723fecfc Check each ID3 tag is valid. 
Some tag encoders like to use non-standard padding (see http://id3.org/Compliance%20Issues) which was causing "unexpected EOF" errors.  Checking that each tag has a valid name (as per the spec) seems to be the only good way around this.
 2015-06-28 09:53:07 +10:00
David Howden 1b0e92375a Fix: panic on empty description in text-description frames. 2015-06-27 19:24:33 +10:00
David Howden d3e0c4a33f Simplify MusicBrainz Info type and support more tags. 2015-06-08 11:01:32 +10:00
David Howden c06066fd88 Updated package godoc comment. 2015-06-07 13:01:12 +10:00
David Howden 6df4e78d96 Remove non-relative Seek calls from all functions. 
Previously we would seek to the beginning of the io.ReadSeeker. It is much more
flexible to assume that the caller passes the ReadSeeker in an appropriate state.
 2015-06-07 12:58:58 +10:00
David Howden 7f8f21cc46 Added flag.Usage output to check tool. 2015-06-07 12:54:44 +10:00
David Howden 4d2e737694 Remove old TODO comment. 2015-06-06 16:35:44 +10:00
David Howden ddaa43f29c Added some more godoc comments. 2015-06-06 16:35:44 +10:00
David Howden 6cd7fd8f70 Added -mbz option to tag tool to output MusicBrainz information. 2015-06-06 16:35:44 +10:00
David Howden e7f103ff85 Improved default usage output to use flag.PrintDefaults(). 2015-06-06 16:35:44 +10:00
David Howden 9534e41d81 Added mbz subpackage for extracting MusicBrainz-specific tags. 
This is a rewrite of pull request #11 which was a first attempt at this (thanks @xhenner for starting this).
 2015-06-06 16:35:39 +10:00
David Howden d03fdf9fb5 Remove debugging output 2015-05-27 18:58:35 +10:00
David Howden 36d9163868 Refactored all MP4 code to better handle custom atoms 2015-05-27 08:43:47 +10:00
David Howden e6dce4ae2a Merge branch 'xhenner-allmp4' 2015-05-25 22:50:42 +10:00
David Howden 3f92286cdb Merge branch 'allmp4' of https://github.com/xhenner/tag into xhenner-allmp4 2015-05-25 22:36:14 +10:00
David Howden ffefb50681 Merge pull request #9 from xhenner/allid3v2 
Fix a bug in Sum() and add all id3frames in Raw()
 2015-05-25 07:36:38 +10:00
David Howden 5ed21afced Added Lyrics() to README 2015-05-24 22:49:06 +10:00
David Howden 8bdc82eff0 Added Genre() to Metadata interface 2015-05-24 22:37:21 +10:00
David Howden ce0c1dc2f8 Remove append no-op! 2015-05-24 13:13:43 +10:00
David Howden 2cbec0cf93 Fix panic when len(result[1]) == 0 2015-05-24 13:13:32 +10:00
David Howden 47d9285956 Small refactor to dataSplit 2015-05-24 13:13:06 +10:00
David Howden 5da0ca1f03 Removed unnecessary space 2015-05-24 12:23:31 +10:00
David Howden 7d23e28e65 Refactor readTextWithDescr function 2015-05-24 12:23:30 +10:00
David Howden b55f474bf9 Refactor readTFrame and added readWFrame 2015-05-24 12:23:30 +10:00
David Howden f782cbdf44 Add check for size of provider/identifier split 2015-05-24 12:23:30 +10:00
David Howden 1832dec4e7 Refactor Ufid -> UFID 2015-05-24 12:23:30 +10:00
David Howden 255636cc34 Update README to add OGG 2015-05-24 11:29:38 +10:00
David Howden 4c2b34fa94 Reorganised Vorbis Comment parsing into own type 
- Added FileType to Metadata to distinguish between FLAC and OGG
- TODO: fix ALAC files being identified as AAC
 2015-05-24 10:44:45 +10:00
David Howden 77d9aa6414 Added tool for checking tags over iTunes Library or path 2015-05-24 09:52:44 +10:00
David Howden e5e85d7360 Merge branch 'Simon-L-master' 2015-05-24 09:50:28 +10:00
David Howden e5ad564af4 Added Lyrics output to tag tool 2015-05-19 22:10:04 +10:00
David Howden 68d82a6107 Fix errors caused by incorrect delimiters 2015-05-19 22:09:51 +10:00
David Howden 3c6f62d3e8 Merge pull request #5 from dhowden/revert-4-lyrics 
Revert "Add support for lyrics."
 2015-05-19 08:04:14 +10:00
David Howden c895efbcf8 Revert "Add support for lyrics." 2015-05-19 08:03:36 +10:00
David Howden 90c5402ab5 Merge pull request #4 from xhenner/lyrics 
Add support for lyrics.
 2015-05-19 07:22:52 +10:00
David Howden 7a80548ea8 Add some basic tests for utils 2015-05-03 09:59:03 +10:00
David Howden 23cb126fb7 Add license comment to unsynchroniser tests 2015-05-03 09:58:40 +10:00
David Howden 0203dd6bc4 Tidy up unsynchroniser.Read some more 2015-05-03 09:58:13 +10:00
David Howden 5989e00ece Simplified unsynchroniser and added tests 2015-05-02 09:58:05 +10:00
David Howden 5ddbd701bc Merge branch 'xhenner-master' 2015-05-02 09:54:31 +10:00
David Howden 07ab8d2572 Fix merge conflicts 2015-05-02 09:53:58 +10:00
David Howden b549899eb9 Merge pull request #3 from solarnz/editorconfig 
Add a basic editorconfig file
 2015-05-01 23:13:13 +10:00
David Howden de3f502e83 Improved handling of multiple tags with the same name 2015-04-27 23:11:04 +10:00
David Howden 0f6115b228 Fixed panic on tag name length < 4 2015-04-27 22:55:59 +10:00
David Howden 4b3edce02f Fixed godoc 2015-04-27 22:53:37 +10:00
David Howden 48793f15b7 Remove log statement 2015-04-27 22:53:37 +10:00
David Howden 060159f528 Merge pull request #2 from xhenner/multiple_frames 
tag can have multiple frames with the same name
 2015-04-27 08:14:15 +10:00
David Howden d7fe851d27 Added FLAC artwork support 2015-04-15 22:20:10 +10:00
David Howden ea8aa7c735 Updated README 2015-04-15 00:14:53 +10:00
David Howden 4cebcae157 Implemented basic FLAC support (no artwork, yet!) 2015-04-15 00:12:37 +10:00
David Howden 8aff503453 Use Seek instead of discardN 2015-04-15 00:12:30 +10:00
David Howden 1fc6cacf34 Updated ReadFrom to take io.ReadSeeker 2015-04-15 00:06:32 +10:00
David Howden 23f80edc48 Updated README 2015-04-03 15:13:44 +11:00
David Howden e9deeea0e1 Refactored Hash -> Sum and fixed infinite loop issue with SumAtoms 2015-04-03 15:13:39 +11:00
David Howden 208a9e993c Moved Seek into individual implementations 2015-03-30 22:50:20 +11:00
David Howden 2c4b231e7e Updated README to include build icon 2015-03-20 09:09:07 +11:00
David Howden 8ff0b0b87d Added .travis.yml 2015-03-20 09:02:27 +11:00
David Howden 441c2cbe66 Added README 2015-03-19 23:29:03 +11:00
David Howden 9278a7ec07 Initial commit 2015-03-19 23:21:53 +11:00